test: cover resolveSubagentPath candidate resolution

[NiveditJain]

Summary

• Add unit tests for resolveSubagentPath covering each candidate path (project-level log, session-level log, subagents subfolder) plus the priority order when multiple candidates exist.
• Cover the null result when no candidate exists and the safety case where a traversal-style agentId resolves outside the projects path.

Test plan

• bun run test:run — new __tests__/lib/resolve-subagent-path.test.ts passes.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Added comprehensive test coverage for path resolution functionality, including verification of resolution priority across multiple candidate locations, validation of null returns for missing files, and security checks against path traversal attempts.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4f7b3c52-583c-4f38-bdc5-1168f6b67ddc

📥 Commits

Reviewing files that changed from the base of the PR and between 1bf509c and 53f51a9.

📒 Files selected for processing (1)

• __tests__/lib/resolve-subagent-path.test.ts

---

📝 Walkthrough

Walkthrough

This PR adds comprehensive test coverage for the resolveSubagentPath function, validating path resolution priority across three candidate file locations, null behavior when files are missing, and security checks preventing path traversal outside the configured projects root.

Changes

resolveSubagentPath Test Coverage

Layer / File(s)	Summary
Test suite for resolveSubagentPath __tests__/lib/resolve-subagent-path.test.ts	Vitest test suite with temporary fixture setup/teardown, file creation helpers, and assertions covering candidate file priority (project-level agent log → session-level agent log → session-level subagents directory log), null return when no files exist, and rejection of paths outside the configured projectsPath root.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

• Add unit tests for lib/resolve-subagent-path.ts #328: This test suite directly validates the resolveSubagentPath behavior (three candidate path priorities, null when missing, and path-traversal rejection) expected from that issue.

Poem

🐰 A test suite hops along the path,
Three candidates checked with rabbit's wrath,
When none exist, it returns null with grace,
No traversal sneaks beyond its space! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding test coverage for the resolveSubagentPath function's candidate resolution logic.
Description check	✅ Passed	The description provides a clear summary of what was added and explains the test plan, though it doesn't include the Type of Change checkboxes or the verification checklist from the template.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}