Skip to content

Make the MishapInvalidIota lang fallback actually work #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
object-Object merged 1 commit into from
Jan 17, 2026
Merged

Make the MishapInvalidIota lang fallback actually work #994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidIota.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,13 @@ class MishapInvalidIota(

override fun errorMessage(ctx: CastingEnvironment, errorCtx: Context): Component? {
val perpKey = HexIotaTypes.REGISTRY.getKey(perpetrator.getType())
val perpDesc = Component.translatableWithFallback(
"hexcasting.iota.${perpKey}.desc",
"hexcasting.mishap.invalid_value.class.${perpKey?.getPath()}"
)

// this translation key is preferred because it includes the namespace
var perpDesc = Component.translatableWithFallback("hexcasting.iota.${perpKey}.desc", "no desc found")
// for addons that don't implement the .desc key, grab the non-namespaced invalid_value key instead
if (perpDesc.getString() == "no desc found")
perpDesc = Component.translatable("hexcasting.mishap.invalid_value.class.${perpKey?.getPath()}")

return error(
"invalid_value", expected, reverseIdx,
perpDesc, perpetrator.display()
Expand Down
Loading