Java Assignment3 upload by HoyunJung#30
Open
ho30archive wants to merge 1 commit intoFastCampusKDTBackend:mainfrom
Open
Java Assignment3 upload by HoyunJung#30ho30archive wants to merge 1 commit intoFastCampusKDTBackend:mainfrom
ho30archive wants to merge 1 commit intoFastCampusKDTBackend:mainfrom
Conversation
111coding
approved these changes
Apr 26, 2023
| if(company == null) return null; | ||
| if(allElectronics == null) return null; | ||
|
|
||
| Electronic[] groupByCN = new Electronic[allElectronics.size()]; |
There was a problem hiding this comment.
몇개인지 모르는 상황에서는 저라면 컬렉션(ArrayList)을 사용한 뒤 loop 후 반복문이 끝난 뒤 배열로 바꿔줄 것 같아요. 필터링된 리스틀만 리턴받는 메소드에서 리턴 받은 후 외부에서 해당 배열의 길이를 사용하는 로직이 있게되면 로직이 꼬이게 되거든요
| if(authMethod == null) return null; | ||
| if(allElectronics == null) return null; | ||
|
|
||
| Electronic[] groupByAM = new Electronic[allElectronics.size()]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
클린한 코드인지 확인 부탁드립니다! Electronics.class의 groupByAuthMethod와 groupByCompanyName가 올바르게 작성된건지 궁금합니다.