Skip to content

fix: reorder between MatchesShape and ProxySetHandlerTargetCheck execution #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piquark6046 wants to merge 1 commit into from
Closed

fix: reorder between MatchesShape and ProxySetHandlerTargetCheck execution #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions userscript/source/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/return *[A-Za-z.-9]+ *\( *[0-9a-fx *+-]+ *, *[A-Za-z.-9]+ *, *[A-Za-z.-9]+ *, *[0-9a-fx *+-]+ *,[A-Za-z.-9]+ *, *[A-Za-z.-9]+ * *\) *; *}/
]]

function PowerLinkElementFromArg(Arg: unknown): HTMLElement | null {

Check warning on line 34 in userscript/source/index.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

'PowerLinkElementFromArg' is defined but never used

Check warning on line 34 in userscript/source/index.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

'PowerLinkElementFromArg' is defined but never used
if (typeof Arg !== 'object' || Arg === null) return null
if (typeof OriginalReflectApply(OriginalObjectGetOwnPropertyDescriptor, BrowserWindow.Object, [Arg, '_'])?.get === 'function') return null

Expand Down Expand Up @@ -414,7 +414,7 @@
console.debug(`[${UserscriptName}]: Proxy set called for PowerLink Skeleton:`, SetArgs)
return
}
if (ProxySetHandlerTargetCheck(SetArgs[0]) && MatchesShape({
if (MatchesShape({
Dummy: [],
PowerLinkTracking: [
{
Expand All @@ -433,7 +433,7 @@
No: 0
}
]
}, SetArgs[0])) {
}, SetArgs[0]) && ProxySetHandlerTargetCheck(SetArgs[0])) {
console.debug(`[${UserscriptName}]: Proxy set called for PowerLink Skeleton (target check):`, SetArgs)
BrowserWindow.document.dispatchEvent(new CustomEvent('PL2PlaceHolderProxy'))
return
Expand Down
Loading