Skip to content

feat: auto detect package manager#456

Open
nstringham wants to merge 2 commits into
FirebaseExtended:mainfrom
nstringham:main
Open

feat: auto detect package manager#456
nstringham wants to merge 2 commits into
FirebaseExtended:mainfrom
nstringham:main

Conversation

@nstringham
Copy link
Copy Markdown

fixes #455 by auto detecting if the user's project uses npm, yarn, or pnpm.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 23, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces dynamic package manager detection to determine whether to use npx, yarn dlx, or pnpm dlx when executing firebase-tools, based on the presence of project lock files. Feedback suggests addressing compatibility issues with Yarn 1.x, which does not support the dlx command, and optimizing performance by caching the detected package manager to avoid repeated synchronous file system checks.

Comment thread src/deploy.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Action fails when devEngines packageManager is set to pnpm

1 participant