Skip to content

fix: Use *bool for EnforceFeatureOwners to allow setting false#20

Merged
gagantrivedi merged 1 commit intomainfrom
fix/enforce-feature-owners-omitempty
Apr 6, 2026
Merged

fix: Use *bool for EnforceFeatureOwners to allow setting false#20
gagantrivedi merged 1 commit intomainfrom
fix/enforce-feature-owners-omitempty

Conversation

@gagantrivedi
Copy link
Copy Markdown
Member

Summary

  • Change EnforceFeatureOwners from bool to *bool in Project struct
  • With bool + omitempty, false is the zero value and gets omitted from JSON, making it impossible to disable the setting once enabled
  • With *bool + omitempty, false is serialized correctly; only nil is omitted

Test plan

  • TestUpdateProjectEnforceFeatureOwnersFalse — verifies false is present in the request payload
  • TestGetProject — updated to assert *bool deserialization
  • All existing tests pass

@gagantrivedi gagantrivedi marked this pull request as ready for review April 6, 2026 08:26
@gagantrivedi gagantrivedi requested a review from a team as a code owner April 6, 2026 08:26
@gagantrivedi gagantrivedi requested review from Zaimwa9 and removed request for a team April 6, 2026 08:26
@gagantrivedi gagantrivedi merged commit d4a039a into main Apr 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants