Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
|
Didn't test the actual code, but the events and definitions look good! |
talissoncosta
left a comment
There was a problem hiding this comment.
Looks good, good job @Zaimwa9
talissoncosta
left a comment
There was a problem hiding this comment.
Looks good. The tracking events are well-structured with useful metadata, and the useRef guard for deduplicating view events works correctly since the component is modal-scoped and unmounts between features.
One minor note: the indentation fix in ProjectNavbar.tsx is unrelated — consider mentioning it in the PR description.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
code_references_click_permalink,code_references_expand_repo,code_references_view,code_references_click_docsHow did you test this code?
On prod, getting the events as follows: