Skip to content

feat(saas-billing): Invoice immediately for new seats #7086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewelwell merged 2 commits into from
Apr 2, 2026
+5 −5
Merged

feat(saas-billing): Invoice immediately for new seats #7086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36120b0
Invoice immediately for new seats
matthewelwell Mar 31, 2026
a7885eb
Update addon id
matthewelwell Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/organisations/chargebee/chargebee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def add_single_seat(subscription_id: str) -> None:
)
],
prorate=True,
invoice_immediately=False,
invoice_immediately=True,
),
)

Expand Down
2 changes: 1 addition & 1 deletion api/organisations/chargebee/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ADDITIONAL_SEAT_ADDON_ID = "additional-team-members-scale-up-v2-monthly"
ADDITIONAL_SEAT_ADDON_ID = "additional-team-members-scale-up-v2"

ADDITIONAL_API_START_UP_ADDON_ID = "additional-api-start-up-monthly"
ADDITIONAL_API_SCALE_UP_ADDON_ID = "additional-api-scale-up-monthly"
6 changes: 3 additions & 3 deletions api/tests/unit/organisations/chargebee/test_unit_chargebee_chargebee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ def test_add_single_seat__existing_addon__increments_quantity(mocker) -> None:
)
],
prorate=True,
invoice_immediately=False,
invoice_immediately=True,
),
)

Expand Down Expand Up @@ -585,7 +585,7 @@ def test_add_single_seat__no_existing_addon__creates_addon_with_quantity_one( #
)
],
prorate=True,
invoice_immediately=False,
invoice_immediately=True,
),
)

Expand Down Expand Up @@ -637,7 +637,7 @@ def test_add_single_seat__api_error__raises_upgrade_seats_error( # type: ignore
)
],
prorate=True,
invoice_immediately=False,
invoice_immediately=True,
),
)
assert len(caplog.records) == 1
Expand Down
Loading