feat: experiments ux improvements#7644
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
There was a problem hiding this comment.
Code Review
This pull request introduces several updates to the experiments and feature flags UI, including cache invalidation for 'FeatureList' when project flags change, layout and styling improvements for the variation table, and resetting the creation state when switching environments. However, a critical issue was identified in both SetupStep.tsx and ReviewStep.tsx: the fallback logic for 'controlValue' incorrectly uses the project-level 'initial_value' when an environment-specific override is null or undefined. It is recommended to explicitly check for the existence of 'environment_feature_state' first to ensure environment overrides are correctly respected.
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements to the experiments UI, including updating cache invalidation tags for FeatureList, styling adjustments for the VariationTable and scrollbars, wrapping the metrics search input in a flex container, and retrieving the control value from the environment feature state instead of the initial value. Additionally, it resets the creation state when the environment changes. Feedback on the changes suggests replacing the hardcoded VARIANT_LETTERS string with a helper function to dynamically generate Excel-like alphabetical labels (e.g., A, B, ... Z, AA, AB) to gracefully handle more than 26 variations.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
variant A/B/C/Ninstead of variant valueinitial_valueHow did you test this code?
Before


After

