Skip to content

feat: experiments ux improvements#7644

Open
Zaimwa9 wants to merge 6 commits into
mainfrom
feat/experiments-ui-improvements
Open

feat: experiments ux improvements#7644
Zaimwa9 wants to merge 6 commits into
mainfrom
feat/experiments-ui-improvements

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented May 29, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Added scrollbar in MV features dropdown
  • Invalidate RTK cache of features when updating a feature value (so the list is up to date in experiment)
  • Closes experiment wizard on environment switch
  • Improved Variant table UI
  • Name in Variant table is actually variant A/B/C/N instead of variant value
  • Fixed a bug getting the control value from initial_value
  • properly fixed search metrics bar

How did you test this code?

Before
image
image

After
image
image

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 29, 2026 15:20
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team May 29, 2026 15:20
@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment May 29, 2026 4:04pm
flagsmith-frontend-staging Ready Ready Preview, Comment May 29, 2026 4:04pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 29, 2026 4:04pm

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7644 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7644 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7644 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7644 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7644 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7644 Finished ✅ Results

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several updates to the experiments and feature flags UI, including cache invalidation for 'FeatureList' when project flags change, layout and styling improvements for the variation table, and resetting the creation state when switching environments. However, a critical issue was identified in both SetupStep.tsx and ReviewStep.tsx: the fallback logic for 'controlValue' incorrectly uses the project-level 'initial_value' when an environment-specific override is null or undefined. It is recommended to explicitly check for the existence of 'environment_feature_state' first to ensure environment overrides are correctly respected.

Comment thread frontend/web/components/experiments/steps/SetupStep.tsx
Comment thread frontend/web/components/experiments/steps/ReviewStep.tsx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.7 seconds
commit  91344d9
info  🔄 Run: #17109 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.9 seconds
commit  91344d9
info  🔄 Run: #17109 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.9 seconds
commit  91344d9
info  🔄 Run: #17109 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  49.4 seconds
commit  91344d9
info  🔄 Run: #17109 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  32.2 seconds
commit  8a3aa80
info  🔄 Run: #17111 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.2 seconds
commit  8a3aa80
info  🔄 Run: #17111 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.7 seconds
commit  8a3aa80
info  🔄 Run: #17111 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  36.8 seconds
commit  8a3aa80
info  🔄 Run: #17111 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.5 seconds
commit  542e23c
info  🔄 Run: #17112 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.9 seconds
commit  542e23c
info  🔄 Run: #17112 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  38.4 seconds
commit  542e23c
info  🔄 Run: #17112 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  40.9 seconds
commit  542e23c
info  🔄 Run: #17112 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Visual Regression

19 screenshots compared. See report for details.
View full report

@Zaimwa9
Copy link
Copy Markdown
Contributor Author

Zaimwa9 commented May 29, 2026

@gemini-code-assist review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several improvements to the experiments UI, including updating cache invalidation tags for FeatureList, styling adjustments for the VariationTable and scrollbars, wrapping the metrics search input in a flex container, and retrieving the control value from the environment feature state instead of the initial value. Additionally, it resets the creation state when the environment changes. Feedback on the changes suggests replacing the hardcoded VARIANT_LETTERS string with a helper function to dynamically generate Excel-like alphabetical labels (e.g., A, B, ... Z, AA, AB) to gracefully handle more than 26 variations.

Comment thread frontend/web/components/experiments/VariationTable/VariationTable.tsx Outdated
Comment thread frontend/web/components/experiments/VariationTable/VariationTable.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant