Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Everything 1.5 is becoming more stable, we should consider using their new SDK to invoke it. Sadly it seems no nuget package for it yet so we have to implement our own solution.
Summary by cubic
Adds optional support for Everything 1.5 (SDK v3) in
Flow.Launcher.Plugin.Explorer, with automatic fallback to 1.4. Adds result highlighting, improves fast-sort detection, and fixes missing results by using the 1.5 search APIs when available.Summary of changes
Changed
Everything_*.Everything3_AddSearchSort; fast-sort detection usesEverything3_IsPropertyFastSort.DLLinstead of hardcoded "Everything64.dll".IsExcludedFilenow safely handles emptyFullPath.Added
Everything3.dllforx86/x64(copied to output) and loading during plugin init.Everything3ApiDllImportwith 1.5 P/Invokes, connection to instance "1.5a", search state/result parsing (full path, type, run count), and highlighted name/path extraction to populate result highlight data.Removed
DLLconstant.Memory usage
Everything3.dll. 1.5 searches allocate and free native search state and result lists per query; no persistent allocations.Security
Everything3.dllfrom the plugin directory; same trust model as existingEverything.dll. Uses local IPC only; no new network or file-write surfaces.Unit tests
Written for commit 9246dea. Summary will update on new commits.