Fix Mass Assignment in Chatflow Endpoints

[christopherholland-workday]

Flowise-301

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical security concern by hardening the chatflow creation and update endpoints. It ensures that only explicitly allowed properties from client requests can modify a ChatFlow object, thereby preventing malicious or accidental overwrites of sensitive data and improving the overall robustness of the application's data handling.

Highlights

• Security Enhancement: Implemented explicit allowlisting for properties when creating and updating chatflows, mitigating potential mass assignment vulnerabilities by preventing unauthorized modification of sensitive fields like id, workspaceId, and timestamps.
• Code Refactoring: Replaced the generic Object.assign method with individual property assignments for ChatFlow objects in both the saveChatflow and updateChatflow functions, ensuring tighter control over data integrity.

Changelog

• packages/server/src/controllers/chatflows/index.ts
  • Modified the saveChatflow function to explicitly assign properties from the request body to a new ChatFlow instance, replacing the Object.assign call.
  • Modified the updateChatflow function to explicitly assign properties from the request body to an existing ChatFlow instance, replacing the Object.assign call.
• packages/server/src/services/chatflows/index.ts
  • Added a defense-in-depth measure in the updateChatflow service function to ensure the workspaceId is always derived from the existing chatflow, preventing client-side overrides.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances security by replacing Object.assign with explicit allowlists for properties when creating and updating chatflows in saveChatflow and updateChatflow functions. This prevents clients from overriding sensitive fields like id or workspaceId. Additionally, a defense-in-depth measure was added in the updateChatflow service to ensure the workspaceId is always derived from the existing database record, further preventing client-side manipulation of this critical identifier.