Fix Mass Assignment in Variables Endpoints

[christopherholland-workday]

Flowise-304

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical security vulnerability related to mass assignment in the variables endpoints. By replacing broad Object.assign operations with explicit property assignments, it prevents unauthorized modification of sensitive fields like id, workspaceId, and timestamps during variable creation and updates. Additionally, a defense-in-depth mechanism was introduced to safeguard the workspaceId during update operations, further enhancing data integrity and security.

Highlights

• Mass Assignment Prevention (Create): The createVariable endpoint now explicitly assigns allowed properties (name, value, type, workspaceId) from the request body to the new Variable object, replacing the insecure Object.assign method.
• Mass Assignment Prevention (Update): The updateVariable endpoint similarly adopts explicit property assignment for name, value, and type to prevent mass assignment vulnerabilities when updating existing variables.
• Workspace ID Protection: A defense-in-depth measure was added in the updateVariable service to ensure that the workspaceId of a variable cannot be inadvertently or maliciously overridden by client-supplied data.

Changelog

• packages/server/src/controllers/variables/index.ts
  • Updated createVariable to explicitly assign name, value, type, and workspaceId from the request body, mitigating mass assignment.
  • Updated updateVariable to explicitly assign name, value, and type from the request body, mitigating mass assignment.
• packages/server/src/services/variables/index.ts
  • Added a line to explicitly re-assign the original workspaceId to tmpUpdatedVariable before saving, preventing client-side workspaceId manipulation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a mass assignment vulnerability in the variables endpoints by switching from Object.assign to an explicit allowlist of properties. This is a significant security improvement. However, I've identified an issue with the new defense-in-depth measure in the updateVariable service. The logic intended to prevent workspaceId tampering is flawed because of how TypeORM's merge function behaves. I've left a specific comment with a recommendation for a fix.