#20 ignore prefixes for query parameters and cookies#21
Closed
marcrobertscamao wants to merge 2 commits into
Closed
#20 ignore prefixes for query parameters and cookies#21marcrobertscamao wants to merge 2 commits into
marcrobertscamao wants to merge 2 commits into
Conversation
Member
|
@kitsunet i kindoff like the feature to get a readable configuration for a larger cookie zoo. What du you think? |
mficzel
previously approved these changes
Oct 18, 2023
mficzel
left a comment
mficzel
left a comment
Member
There was a problem hiding this comment.
I generally like this and can confirm that it works as documented. My brain does not process array_reduce too well but that is probably more my personal issue.
Member
|
After seeing pr #22 i changed my mind. I think the opt in approach via |
mficzel
requested review from
mficzel
and removed request for
kitsunet and
mficzel
Member
|
@marcrobertscamao would #22 solve your usecase aswell? It has a much simpler structure but kindoff turns the whole problem around. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First implementation to exclude prefixes inline with #20