Skip to content

fix: sanitize custom IM type label before using as IMPP URI scheme #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faraz152 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: sanitize custom IM type label before using as IMPP URI scheme #543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d895782
fix: sanitize custom IM type label before using as IMPP URI scheme
faraz152 Apr 22, 2026
8c14355
fix: handle empty label correctly in IMPP scheme sanitization
faraz152 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion app/src/main/kotlin/org/fossify/contacts/helpers/VcfExporter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,22 @@ class VcfExporter {
Im.PROTOCOL_GOOGLE_TALK -> Impp(HANGOUTS, it.value)
Im.PROTOCOL_QQ -> Impp(QQ, it.value)
Im.PROTOCOL_JABBER -> Impp(JABBER, it.value)
else -> Impp(it.label, it.value)
else -> {
// IMPP URIs use the label as the URI scheme, which only allows
// [a-zA-Z][a-zA-Z0-9+-.]*. Replace any character outside that
// set with a hyphen so labels containing spaces (or other symbols)
// don't throw an IllegalArgumentException and corrupt the export.
val scheme = it.label
.replace(Regex("[^a-zA-Z0-9+\\-.]"), "-")
.let { s ->
when {
s.isEmpty() -> "x-custom"
s.firstOrNull()?.isLetter() != true -> "x-$s"
else -> s
}
}
Impp(scheme, it.value)
}
}

card.addImpp(impp)
Expand Down
Loading