feat: add long press gesture to 2x speed in separate video player #836
+160
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensingh
changed the title
Member
|
You may ignore the |
Contributor
Author
|
Sure @naveensingh . It seems to be working fine on a physical device. But when run on emulator, the screen is turning black I analyzed the apk and found this: |
Member
|
If it's working properly on physical devices, it's okay.
Please ignore that warning. I'll be adding support for 16KB page size in affected apps soon-ish. |
naveensingh
requested changes
Dec 30, 2025
Member
naveensingh
left a comment
naveensingh
left a comment
There was a problem hiding this comment.
Found two bugs:
- When panning after zooming in, the speed is increased even though I was panning. It seems more easily reproducible when panning vertically than horizontally. This does not happen in the normal player, so it shouldn't be about the 500ms delay. If you are unable to reproduce this, try panning the video vertically for a few centimeters and then stop without releasing the touch.
- Long press ➜ speed is increased ➜ release touch ➜ player unnecessary exits/enters full-screen mode.
| mExoPlayer?.setVideoSurface(Surface(binding.videoSurface.surfaceTexture)) | ||
| } | ||
|
|
||
| @RequiresApi(Build.VERSION_CODES.R) |
Member
There was a problem hiding this comment.
Both onSurfaceTextureAvailable() and onSurfaceTextureSizeChanged() were added in API 14.
Suggested change
| @RequiresApi(Build.VERSION_CODES.R) |
|
|
||
| override fun onSurfaceTextureDestroyed(surface: SurfaceTexture) = false | ||
|
|
||
| @RequiresApi(Build.VERSION_CODES.R) |
Member
There was a problem hiding this comment.
Suggested change
| @RequiresApi(Build.VERSION_CODES.R) |
| import android.graphics.SurfaceTexture | ||
| import android.graphics.drawable.ColorDrawable | ||
| import android.net.Uri | ||
| import android.os.Build |
Member
There was a problem hiding this comment.
Suggested change
| import android.os.Build |
Comment on lines
854
to
866
| /*@RequiresApi(Build.VERSION_CODES.R) | ||
| fun setPillHeight() { | ||
| val system = WindowInsets.CONSUMED.getInsetsIgnoringVisibility(Type.systemBars()) | ||
| val pillTopMargin = system.top + resources.getActionBarHeight(this) + | ||
| resources.getDimension(org.fossify.commons.R.dimen.normal_margin).toInt() | ||
| (mPlaybackSpeedPill.layoutParams as? RelativeLayout.LayoutParams)?.apply { | ||
| setMargins( | ||
| 0, pillTopMargin, 0, 0 | ||
| ) | ||
| } | ||
| }*/ | ||
|
|
Member
There was a problem hiding this comment.
Might as well remove it if we don't need it.
Suggested change
| /*@RequiresApi(Build.VERSION_CODES.R) | |
| fun setPillHeight() { | |
| val system = WindowInsets.CONSUMED.getInsetsIgnoringVisibility(Type.systemBars()) | |
| val pillTopMargin = system.top + resources.getActionBarHeight(this) + | |
| resources.getDimension(org.fossify.commons.R.dimen.normal_margin).toInt() | |
| (mPlaybackSpeedPill.layoutParams as? RelativeLayout.LayoutParams)?.apply { | |
| setMargins( | |
| 0, pillTopMargin, 0, 0 | |
| ) | |
| } | |
| }*/ |
| import android.widget.RelativeLayout | ||
| import android.widget.SeekBar | ||
| import android.widget.TextView | ||
| import androidx.annotation.RequiresApi |
Member
There was a problem hiding this comment.
Suggested change
| import androidx.annotation.RequiresApi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
Before & after preview
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).