Skip to content

Fix captcha widget regression #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Inverle merged 1 commit into from
Jun 3, 2026
Merged

Fix captcha widget regression #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions xExtension-Captcha/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ If you are having trouble with logging in after configuring the extension, you c

## Changelog

* 1.0.6 [2026-06-04]
* Fixed captcha widget not loading due to wrong method visibility on the `Minz_HookType::BeforeLoginBtn` hook, this was a regression introduced in the last (v1.0.5) version [#475](https://github.com/FreshRSS/Extensions/issues/475)
* 1.0.5 [2026-03-14]
* Ensure controller is hooked properly, even when other extensions are also hooking the same controller, by using new `Minz_HookType::ActionExecute` hook
* Fixed a bug where captcha was being verified when creating a user as admin
Expand Down
4 changes: 2 additions & 2 deletions xExtension-Captcha/extension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function handleProtectedPage(Minz_ActionController $controller): bool {
$csp = $this->loadDependencies();
if (!empty($csp)) $controller->_csp($csp);
} elseif (Minz_Request::is('user', 'create') && !FreshRSS_Auth::hasAccess('admin')) {
if (!CaptchaExtension::initCaptcha()) {
if (!$this->initCaptcha()) {
Copy link
Copy Markdown
Member Author

@Inverle Inverle Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is not related to the bug, just for consistency to match the if above

return false;
}
}
Expand All @@ -58,7 +58,7 @@ private function getClientIp(): string {
/**
* @throws FreshRSS_Context_Exception
*/
private function captchaWidget(): string {
public function captchaWidget(): string {
$config = self::getConfig();
if (!$this->isProtectedPage()) {
return '';
Expand Down
2 changes: 1 addition & 1 deletion xExtension-Captcha/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Form Captcha",
"author": "Inverle",
"description": "Protect register/login forms with captcha",
"version": "1.0.5",
"version": "1.0.6",
"entrypoint": "Captcha",
"type": "system"
}