DECO-2251 Encrypted files in VaaS#974
Open
jbg-1 wants to merge 1 commit into
Open
Conversation
GermanCoding
reviewed
Jun 2, 2026
Collaborator
GermanCoding
left a comment
GermanCoding
left a comment
There was a problem hiding this comment.
Two nits, otherwise OK
Comment on lines
+192
to
+202
| [Fact] | ||
| public void Reports_DeserializeIsEncryptedFromApiPayload() | ||
| { | ||
| const string fileReportJson = | ||
| """ | ||
| {"sha256":"c0621519a2dd9336b12dc6caef2cc789f23eef3026916638dcd620d0ac193881","verdict":"Clean","isEncrypted":true} | ||
| """; | ||
| const string urlReportJson = | ||
| """ | ||
| {"sha256":"79fae1ed9ff540bc286f6cc79c7fbaef323987d17e182ee20f13b0285038d8ed","verdict":"Malicious","url":"https://samples.develop.vaas.gdatasecurity.de/with-and-without-password.zip","isEncrypted":true} | ||
| """; |
Collaborator
There was a problem hiding this comment.
Should be refactored to use a theory with two tests I think
Implement IsEncrypted for C# SDK
pstadermann
force-pushed
the
cs/is_encrypted
branch
from
68b1ce7 to
d0f9d7b
Compare
doxthree
reviewed
Jun 3, 2026
| } | ||
|
|
||
| [Fact] | ||
| public async Task ForFileAsync_IfContainsEicarAndEncryptedArchive_ReturnsMaliciousAndIsEncrypted() |
| public class FileReportTest | ||
| { | ||
| [Fact] | ||
| public void Deserialize_ReturnsIsEncrypted() |
| public class UrlReportTest | ||
| { | ||
| [Fact] | ||
| public void Deserialize_ReturnsIsEncrypted() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement IsEncrypted for C# SDK