-
Notifications
You must be signed in to change notification settings - Fork 15
Typos/errors found by user vabe44 #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cvl75
wants to merge
33
commits into
GDIBass:main
Choose a base branch
from
cvl75:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed all errors (almost) reported by yamllint
Introduced new hero Zavolt with detailed stats, abilities, and passives in YAML format, and added corresponding image asset.
Corrected line breaks and formatting in passive ability descriptions for Rhineglow, Scath, Shacklebolt, and Shaal to improve readability. Updated Iron-Heart's Killer Bot Minion HP from 22% to 27%.
Added Experience Mimic Fire Rare and Ascension Mimic Holy Epic hero data, including images. Introduced a new source entry for Bazaar Summon.
Renamed the hero image file for consistency in naming, changing 'red' to 'fire' to better reflect the element naming convention.
Introduced a new 'element' property for each color (purple, yellow, blue, green, red) in colors.yml to specify their associated element type.
Introduced a new hero, Crustee, with detailed stats, skills, and passives in data/heroes/green/5/Crustee.yml. Added corresponding hero image at img/heroes/crustee.jpg.
Added new frame images for blue, green, purple, red, and yellow colors, covering levels 3, 4, and 5. These assets will support additional visual options or progression indicators in the application.
Introduces new heroes Lempi (blue, 5*), Vernon (green, 5*), and adds costumes for Zarola (green, 3*), Cupido (red, 5*), and Voluptas (yellow, 4*). Updates the Cupid family bonus details and passives for several heroes. Adds corresponding hero and costume images.
Standardized the 'Resist Special Skill Blocking' passive to state immunity to status ailments preventing Special Skills. Improved clarity and consistency in effect descriptions and type labels for several heroes.
Introduced a new yellow dragon, Gonthrox, with its stats, abilities, and assist skill in the data directory. Added corresponding image for Gonthrox.
Introduced a new blue 5-star hero, Gitnib, including detailed stats, abilities, passives, and associated image. This addition expands the hero roster with unique skills and mechanics.
Introduced new hero 'Ibelis' with detailed stats, skills, and passives in the yellow/5 category. Added corresponding hero image.
Added new green 5-star hero Laurent with full stats, skills, and image. Introduced a costume for Porthos with new abilities and image. Updated Dominique, The Beast, and Rose de Flo to include the 'Humility' type and made minor skill adjustments to Dominique.
Introduced new hero 'Lumi & Taiga' with full stats, abilities, and passives in YAML format, and added corresponding hero image.
Introduced the 'Elkanen Stylish Costume' with new stats, abilities, and passives. Updated Elkanen.yml to include the new costume as 'costume5' and added corresponding images.
Introduces the new 'Stylish Costume' for Caedmon, including its stats, skills, effects, and passive ability. Updates Caedmon's main YAML to include the new costume and adds associated images.
Introduced the Aether Mimic Nature hero with stats, abilities, and passives in YAML format, and added the corresponding hero image.
Add new hero 'Veer' (purple, 5*) data file with stats, class, skill 'Bagh Nakh Thrust', effects (Growth Boon, dodge buff, damage on dodge), passives (mana on damage, extra damage to minions) and external image URL. Also add local portrait image img/heroes/veer.jpg so the hero can be displayed in the app.
Add new red hero 'Chingiriko' (data/heroes/red/5/Chingiriko.yml) containing stats, skill 'Sling-ja Attack', effects, types, passives and metadata (source: superelemental, family: slime, class: Ranger). Also add corresponding image file img/heroes/chingiriko.jpg.
Standardize Sticky Surface effect wording and type labels across multiple hero YAMLs. Updates effect strings to a consistent phrasing (including adding “or Growth effect” where missing and normalizing quoting), renames type entries from variants like "Sticky Surface All"/"Sticky Surface All Allies" to "Sticky Surface Buff All" (and "Sticky Surface Buff 3"), and fixes capitalization/typos in Fungustine's type list (e.g. "Healt Boost all" -> "Health Boost All"). Affected files: Choozen, Boboo Sang, Fungustine, Verdigoo, Gooze.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing those bugs, I introduced many more with find-in-files & replace-all :D
Fixed it finally