[Reviewed] [3D spot light] Light up a cone like a flashlight by D8H · Pull Request #2075 · GDevelopApp/GDevelop-extensions

D8H · 2026-03-31T08:37:46Z

No description provided.

extensions/reviewed/SpotLight3D.json

4ian · 2026-03-31T12:18:11Z

extensions/reviewed/SpotLight3D.json

+                "/** @type {gdjs.CustomRuntimeObject} */",
+                "const object = objects[0];",
+                "// Here runtimeScene is the gdjs.CustomRuntimeObjectInstanceContainer inside the custom object.",
+                "const gameScene = object.getRuntimeScene();",


Nitpicking: unused variable?

4ian · 2026-03-31T12:19:48Z

extensions/reviewed/SpotLight3D.json

+            "            break;",
+            "        }",
+            "        this.spotLight.shadow.mapSize.width = size;",
+            "        this.spotLight.shadow.mapSize.height = size;",


For directional light I had to dispose, set to null and then set it again to force the re-creation:

Not sure if you need a dirty flag or not, just flagging this.

extensions/reviewed/SpotLight3D.json

github-actions · 2026-03-31T17:32:02Z

Errors were detected in this submission:

❌ 1 Error found in extension 'SpotLight3D':

  ⟶ ❌ [JavaScript disallowed properties]: JavaScript usage of the extension 'SpotLight3D' must be checked by the reviewer:
{
  allowedProperties: [
    'makeUuid',
    'rgbToHex',
    'rgbOrHexToRGBColor',
    'rgbToHexNumber',
    'hexNumberToRGB',
    'hexToRGBColor',
    'rgbOrHexStringToNumber',
    'hexNumberToRGBArray',
    'copyArray',
    'staticArray',
    'staticArray2',
    'staticObject',
    'toDegrees',
    'toRad',
    'random',
    'randomFloat',
    'randomFloatInRange',
    'randomInRange',
    'randomWithStep',
    'evtTools',
    'Variable',
    'RuntimeObject',
    'Logger',
    '__spotLight3DExtension',
    'CustomRuntimeObject',
    'CustomRuntimeObjectInstanceContainer',
    'CustomRuntimeObject3DRenderer',
    'CustomRuntimeObject3D',
    'registerRuntimeScenePreEventsCallback',
    'registerInGameEditorPostStepCallback',
    'scene3d'
  ],
  disallowedProperty: 'RuntimeScene',
  objectName: 'gdjs'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw',
    '__spotLight3DExtension'
  ],
  disallowedProperty: 'getScene',
  objectName: 'runtimeScene'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw',
    '__spotLight3DExtension'
  ],
  disallowedProperty: '__spotLightManager',
  objectName: 'runtimeScene'
}


❌ 1 Error found in extensions - please fix it before generating the registry.
No fatal error found the extension can be updated but still need fixes.

github-actions · 2026-03-31T19:59:19Z

Errors were detected in this submission:

❌ 1 Error found in extension 'SpotLight3D':

  ⟶ ❌ [JavaScript disallowed properties]: JavaScript usage of the extension 'SpotLight3D' must be checked by the reviewer:
{
  allowedProperties: [
    'makeUuid',
    'rgbToHex',
    'rgbOrHexToRGBColor',
    'rgbToHexNumber',
    'hexNumberToRGB',
    'hexToRGBColor',
    'rgbOrHexStringToNumber',
    'hexNumberToRGBArray',
    'copyArray',
    'staticArray',
    'staticArray2',
    'staticObject',
    'toDegrees',
    'toRad',
    'random',
    'randomFloat',
    'randomFloatInRange',
    'randomInRange',
    'randomWithStep',
    'evtTools',
    'Variable',
    'RuntimeObject',
    'Logger',
    '__spotLight3DExtension',
    'CustomRuntimeObject',
    'CustomRuntimeObjectInstanceContainer',
    'CustomRuntimeObject3DRenderer',
    'CustomRuntimeObject3D',
    'registerRuntimeScenePreEventsCallback',
    'registerInGameEditorPostStepCallback',
    'scene3d'
  ],
  disallowedProperty: 'RuntimeScene',
  objectName: 'gdjs'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw',
    '__spotLight3DExtension'
  ],
  disallowedProperty: 'getScene',
  objectName: 'runtimeScene'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw',
    '__spotLight3DExtension'
  ],
  disallowedProperty: '__spotLightManager',
  objectName: 'runtimeScene'
}


❌ 1 Error found in extensions - please fix it before generating the registry.
No fatal error found the extension can be updated but still need fixes.

[Reviewed] [3D spot light] Light up a cone like a flashlight

78fa8aa

D8H self-assigned this Mar 31, 2026

D8H added the ✨ New extension A new extension label Mar 31, 2026

D8H requested a review from a team as a code owner March 31, 2026 08:37

D8H added the 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. label Mar 31, 2026

D8H added this to Extensions review Mar 31, 2026

github-project-automation bot moved this to Needs review in Extensions review Mar 31, 2026

D8H added 2 commits March 31, 2026 10:51

Remove useless line

08b66d7

Declare JS usage

abc08a5

D8H requested a review from a team as a code owner March 31, 2026 11:05

GDevelopApp deleted a comment from github-actions bot Mar 31, 2026