Fix an obsolete dependency libsystemd-daemon#1
Conversation
The libsystemd-daemon component referred to from within configure.ac is not available in Ubuntu Trusty which is referenced as a recommended platform for building the project. The replacement component is libsystemd. I'm not completely sure that the required minimal version number of 37 is still relevant, the libsystemd version on my Trusty machine reported by pkg-config is 229 which is way higher that the mentioned 37. Build successfully completes after the change. The 'check' make target does not, but that's a different story. https://at.projects.genivi.org/jira/browse/NSM-1
|
@DunderRoffe Would you review this please? |
|
I can certainly do a test build and evaluate this pull-request. However, I do not have access to merging it. |
|
I can confirm that it builds on the GDP platform (when removing a patch that does the same thing as this pull-request from meta-ivi). The patch itself looks good. However, I would recommend conforming to the commit message rules defined at the GENIVI wiki: https://at.projects.genivi.org/wiki/display/PROJ/Rules+for+Commit+Messages |
|
@dliakh Can you respond to the request to follow the commit message rules in your PR? Once that is done I will ping the NSM maintainer to see if they cannot commit this patch. Thanks! |
|
Hi Jeremiah,
Yes. I'll look at that. I'll try to do that by tomorrow.
Thanks
2017-02-16 17:39 GMT+02:00 Jeremiah C. Foster <notifications@github.com>:
… @dliakh <https://github.com/dliakh> Can you respond to the request to
follow the commit message rules in your PR? Once that is done I will ping
the NSM maintainer to see if they cannot commit this patch.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUPdLeKF1FiSwWwZH9JZVkF2GbQQ-_TMks5rdG2rgaJpZM4LbJs1>
.
|
|
I would like to stay backwards compatible and suggest to do the package check like this: PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon libsystemd-login],, |
The libsystemd-daemon component referred to from within configure.ac is not available in Ubuntu Trusty which is referenced as a recommended platform for building the project.
The replacement component is libsystemd.
I'm not completely sure that the required minimal version number of 37 is still relevant, the libsystemd version on my Trusty machine reported by pkg-config is 229 which is way higher that the mentioned 37. Build successfully completes after the change. The 'check' make target does not, but that's a different story.
https://at.projects.genivi.org/jira/browse/NSM-1