Skip to content

Conversation

@arng40
Copy link
Contributor

@arng40 arng40 commented Dec 22, 2025

Missing "," in csv headers and average/min pressure have been reversed

@arng40 arng40 self-assigned this Dec 22, 2025
@arng40 arng40 added type: bug Something isn't working flag: ready for review flag: no rebaseline Does not require rebaseline labels Dec 22, 2025
Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uniformize with the compositionalMultiphaseStatistics.cpp:

  • use a TableLayout in the rows output
  • Also, if it is not too much out of scope, you can keep the formatter as a private member (preventing any different parameter count in the CSV header & data)

Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore my previous comment as I am doing it in #3826

@MelReyCG MelReyCG added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 7, 2026
@dkachuma dkachuma added the ci: run code coverage enables running of the code coverage CI jobs label Feb 2, 2026
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.87%. Comparing base (2acb3ef) to head (620de53).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...physicsSolvers/fluidFlow/SinglePhaseStatistics.cpp 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3928      +/-   ##
===========================================
- Coverage    58.87%   58.87%   -0.01%     
===========================================
  Files         1353     1353              
  Lines       112953   112955       +2     
===========================================
  Hits         66504    66504              
- Misses       46449    46451       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkachuma dkachuma merged commit 498d8e3 into develop Feb 2, 2026
39 of 44 checks passed
@dkachuma dkachuma deleted the fix/dudes/csv-generation branch February 2, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants