-
Notifications
You must be signed in to change notification settings - Fork 99
fix: single phase statistics CSV generation #3928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MelReyCG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uniformize with the compositionalMultiphaseStatistics.cpp:
- use a TableLayout in the rows output
- Also, if it is not too much out of scope, you can keep the formatter as a private member (preventing any different parameter count in the CSV header & data)
MelReyCG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ignore my previous comment as I am doing it in #3826
…V/GEOS into fix/dudes/csv-generation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3928 +/- ##
===========================================
- Coverage 58.87% 58.87% -0.01%
===========================================
Files 1353 1353
Lines 112953 112955 +2
===========================================
Hits 66504 66504
- Misses 46449 46451 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Missing "," in csv headers and average/min pressure have been reversed