perf: Improve MGR recipes for thermal

[victorapm]

Depends on GEOS-DEV/thirdPartyLibs#332

[castelletto1]

What does "Partial column-lumped approximation" mean?

[victorapm]

It means W_{TS} = 0 instead of doing colsum^{-1}(A_{TS}) * colsum^{-1}(A_{SS}) as done by blockColLumped. W_{TS} being the submatrix of the restriction operator coupling temperature and densities.

The pressure part remains the same: W_{PS} = colsum^{-1}(A_{PS}) * colsum^{-1}(A_{SS})

So, I called it a "partial" column-lumped. Let me know if you have other names in mind!

[castelletto1]

So for ThermalCompositionalMultiphaseFVM we have:

| A_SS A_SP A_ST |
| A_PS A_PP A_PT |
| A_TS A_TP A_TT |

With "Partial column-lumped approximation", the correction to block:

| A_PP A_PT |
| A_TP A_TT |

is

- | colsum(A_{PS})  | * colsum^{-1}(A_{SS}) * | A_SP A_ST |
  |       0         |

Correct?

[victorapm]

That's correct, so essentially the energy equation isn't perturbed

[castelletto1]

I like the use of the Galerkin projection instead of the non-Galerkin. Again, I am not sure I fully understand what partial column lumping is.

[castelletto1]

Same comment applies also to the the other two modified strategies

[paveltomin]

would be interesting to discuss this during our solvers meeting on Thursdays

[bmhan12]

Note: This PR is dependent on #3923 .
Pangea builds are no longer being as part of thirdPartyLibs since GEOS-DEV/thirdPartyLibs#331

[codecov]

Codecov Report

❌ Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.87%. Comparing base (0527259) to head (9923988).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ies/ThermalCompositionalMultiphaseReservoirFVM.hpp	0.00%	4 Missing ⚠️
...grStrategies/ThermalCompositionalMultiphaseFVM.hpp	0.00%	2 Missing ⚠️
...e/mgrStrategies/ThermalMultiphasePoromechanics.hpp	0.00%	2 Missing ⚠️
...ts/linearAlgebra/interfaces/direct/SuperLUDist.cpp	0.00%	1 Missing ⚠️
...arAlgebra/interfaces/hypre/HyprePreconditioner.cpp	0.00%	1 Missing ⚠️
...ents/linearAlgebra/interfaces/hypre/HypreUtils.cpp	0.00%	1 Missing ⚠️
...nts/linearAlgebra/interfaces/hypre/HypreVector.cpp	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3939   +/-   ##
========================================
  Coverage    58.87%   58.87%           
========================================
  Files         1353     1353           
  Lines       112954   112953    -1     
========================================
  Hits         66504    66504           
+ Misses       46450    46449    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.