Skip to content

Conversation

@dkachuma
Copy link
Contributor

This PR fixes the transimissibility calculated between a cell and a surface element. This follows the same treatment as CellElementStencilTPFA.

As a side, the logging on vtkExtractEdges results in some info messages in the log. I am disabling the logging temporarily while this filter is running.

Copy link
Contributor

@OmarDuran OmarDuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @dkachuma

Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it is working for SEAM case.
The negative transmissibility is related to the old issue with vtk (inconsistent surface normal with MPI)

@jhuang2601 jhuang2601 added type: bug Something isn't working ci: run CUDA builds Allows to triggers (costly) CUDA jobs Theme - FF Faults & fractures modeling ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 22, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the m_transMultiplier be there too ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this was missing in the derivatives. I have added it. I have also included the fix in the method overload

Base automatically changed from feature/jhuang/multiphaseALM to develop January 26, 2026 16:11
@jhuang2601 jhuang2601 changed the title Fix transmissibility calculation fix: Fix transmissibility calculation Jan 26, 2026
@castelletto1 castelletto1 added the ci: run code coverage enables running of the code coverage CI jobs label Jan 26, 2026
@jhuang2601
Copy link
Contributor

Expected failures for MPI runs and hence rebaseline

=======================
Test failures
=======================
ALM_multiphasePoromechanics_curvedFrac_smoke_02
ALM_singlephasePoromechanics_curvedFrac_smoke_02
multiphasePoromechanics_FaultModel_smoke_04
multiphasePoromechanics_FaultModel_well_fim_smoke_04
multiphasePoromechanics_FaultModel_well_seq_smoke_04
singlePhasePoromechanics_FaultModel_smoke_04

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.87%. Comparing base (951cfc1) to head (30a26de).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...mponents/finiteVolume/FaceElementToCellStencil.hpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3940      +/-   ##
===========================================
- Coverage    58.87%   58.87%   -0.01%     
===========================================
  Files         1353     1353              
  Lines       112946   112953       +7     
===========================================
+ Hits         66502    66504       +2     
- Misses       46444    46449       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@castelletto1 castelletto1 merged commit e90dcd2 into develop Jan 27, 2026
41 of 44 checks passed
@castelletto1 castelletto1 deleted the dkachuma/face-to-cell-stencil branch January 27, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI Theme - FF Faults & fractures modeling type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants