-
Notifications
You must be signed in to change notification settings - Fork 99
fix: Fix transmissibility calculation #3940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OmarDuran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix @dkachuma
jhuang2601
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, it is working for SEAM case.
The negative transmissibility is related to the old issue with vtk (inconsistent surface normal with MPI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the m_transMultiplier be there too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this was missing in the derivatives. I have added it. I have also included the fix in the method overload
|
Expected failures for MPI runs and hence rebaseline |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3940 +/- ##
===========================================
- Coverage 58.87% 58.87% -0.01%
===========================================
Files 1353 1353
Lines 112946 112953 +7
===========================================
+ Hits 66502 66504 +2
- Misses 46444 46449 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR fixes the transimissibility calculated between a cell and a surface element. This follows the same treatment as
CellElementStencilTPFA.As a side, the logging on
vtkExtractEdgesresults in some info messages in the log. I am disabling the logging temporarily while this filter is running.