Skip to content

Conversation

@dkachuma
Copy link
Contributor

Somewhere along the line the proper resizing of the rock thermal conductivity for the volume weighted model was lost. This was resulting in a seg fault in models using this.

@dkachuma dkachuma self-assigned this Jan 22, 2026
@dkachuma dkachuma added the type: bug Something isn't working label Jan 22, 2026
@dkachuma dkachuma added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.87%. Comparing base (e90dcd2) to head (0663baf).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ty/MultiPhaseVolumeWeightedThermalConductivity.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3941   +/-   ##
========================================
  Coverage    58.87%   58.87%           
========================================
  Files         1353     1353           
  Lines       112953   112954    +1     
========================================
+ Hits         66502    66504    +2     
+ Misses       46451    46450    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@castelletto1 castelletto1 merged commit 0527259 into develop Jan 28, 2026
23 of 24 checks passed
@castelletto1 castelletto1 deleted the dkachuma/fix-thermal-conductivity branch January 28, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants