Skip to content

Crossbow Cartridges - Fix torch place fail playing placement sound#1231

Merged
misode merged 4 commits intoGamemode4Dev:masterfrom
runcows:crossbow-cartridges-torch-sound-fix
Jan 15, 2026
Merged

Crossbow Cartridges - Fix torch place fail playing placement sound#1231
misode merged 4 commits intoGamemode4Dev:masterfrom
runcows:crossbow-cartridges-torch-sound-fix

Conversation

@runcows
Copy link
Copy Markdown
Contributor

@runcows runcows commented Dec 8, 2025

Closes #1187

@Bloo-dev Bloo-dev added the fix This fixes something that was wrong label Dec 8, 2025
@runcows
Copy link
Copy Markdown
Contributor Author

runcows commented Jan 12, 2026

Also added copper torch to #gm4_crossbow_cartridges:valid_items since I guess I forgot to for the 1.21.9 update, meaning that it wasn't working this entire time .,,..,

Anyway these changes are now tested in game and work as intended

Copy link
Copy Markdown
Member

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well.

@misode misode merged commit d41cb45 into Gamemode4Dev:master Jan 15, 2026
5 checks passed
github-actions Bot pushed a commit that referenced this pull request Jan 15, 2026
…t sound (#1231)

* Fix torch place sound when place fails

* Torch logic refactoring

* add copper torch to valid items AAAAAAAAAAA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix This fixes something that was wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crossbow Cartridges Torch placement failure shouldn't play the place sound

3 participants