Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant migration of the project's Python dependency management system from Poetry to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
| Pip Install Without Pinned Package Version | Dockerfile | View in code |
☢️ The following Vulnerabilities (CVEs) have been detected
| PACKAGE | FILE | CVE ID | INSTALLED VERSION | FIXED VERSION | ||
|---|---|---|---|---|---|---|
| deepdiff | ./uv.lock | CVE-2025-58367 | 7.0.1 | 8.6.1 | View in code | |
| deepdiff | ./uv.lock | CVE-2026-33155 | 7.0.1 | 8.6.2 | View in code | |
| mysql-connector-python | ./uv.lock | CVE-2024-21272 | 8.0.29 | 9.1.0 | View in code | |
| orjson | ./uv.lock | CVE-2025-67221 | 3.11.5 | 3.11.6 | View in code | |
| protobuf | ./uv.lock | CVE-2026-0994 | 4.25.8 | 6.33.5, 5.29.6 | View in code | |
| pyjwt | ./uv.lock | CVE-2026-32597 | 2.9.0 | 2.12.0 | View in code | |
| pyopenssl | ./uv.lock | CVE-2026-27459 | 25.3.0 | 26.0.0 | View in code | |
| urllib3 | ./uv.lock | CVE-2025-66418 | 1.26.20 | 2.6.0 | View in code | |
| urllib3 | ./uv.lock | CVE-2025-66471 | 1.26.20 | 2.6.0 | View in code | |
| urllib3 | ./uv.lock | CVE-2026-21441 | 1.26.20 | 2.6.3 | View in code |
Note: The scan should have failed if no policies were configured in warn-only mode.
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the project's tooling from Poetry to uv, which should improve performance for local setup and CI. The changes cover updates to pyproject.toml, CI/Docker configurations, and developer documentation. The migration to the standard [project] table in pyproject.toml is well-executed. I've found one critical issue regarding the definition of dependency groups which will prevent development dependencies from being installed correctly. My review includes a suggestion to align it with uv's recommended practice.
| [project.optional-dependencies] | ||
| preql = ["preql>=0.2.19"] | ||
| mysql = ["mysql-connector-python>=8.0.29"] | ||
| postgresql = ["psycopg2"] | ||
| redshift = ["psycopg2"] | ||
| snowflake = ["snowflake-connector-python", "cryptography"] | ||
| snowflake = ["snowflake-connector-python>=3.0.2,<4.0.0", "cryptography"] | ||
| presto = ["presto-python-client"] | ||
| oracle = ["oracledb"] | ||
| mssql = ["pyodbc"] | ||
| # databricks = ["databricks-sql-connector"] | ||
| trino = ["trino"] | ||
| mssql = ["pyodbc>=4.0.39"] | ||
| trino = ["trino>=0.314.0"] | ||
| clickhouse = ["clickhouse-driver"] | ||
| vertica = ["vertica-python"] | ||
| duckdb = ["duckdb"] | ||
| all-dbs = [ | ||
| "preql", "mysql-connector-python", "psycopg2", "snowflake-connector-python", "cryptography", "presto-python-client", | ||
| "oracledb", "pyodbc", "trino", "clickhouse-driver", "vertica-python", "duckdb" | ||
| "preql>=0.2.19", | ||
| "mysql-connector-python>=8.0.29", | ||
| "psycopg2", | ||
| "snowflake-connector-python>=3.0.2,<4.0.0", | ||
| "cryptography", | ||
| "presto-python-client", | ||
| "oracledb", | ||
| "pyodbc>=4.0.39", | ||
| "trino>=0.314.0", | ||
| "clickhouse-driver", | ||
| "vertica-python", | ||
| "duckdb", | ||
| ] | ||
|
|
||
| [tool.poetry.group.dev.dependencies] | ||
| pre-commit = ">=3.5.0" | ||
| [project.scripts] | ||
| data-diff = "data_diff.__main__:main" | ||
|
|
||
| [project.urls] | ||
| Repository = "https://github.com/GannettDigital/data-diff" | ||
|
|
||
| [dependency-groups] | ||
| dev = [ | ||
| "parameterized", | ||
| "unittest-parallel", | ||
| "ruff>=0.1.4", | ||
| "pre-commit>=3.5.0", | ||
| ] | ||
| ci = [ | ||
| "google-cloud-bigquery<3.0.0", | ||
| ] |
There was a problem hiding this comment.
The [dependency-groups] table is not a standard part of pyproject.toml (PEP 621) and is not recognized by uv. To define development or CI dependencies that can be installed with uv sync --extra <group>, they should be moved into [project.optional-dependencies]. This will ensure that commands like uv sync --all-extras correctly install all necessary dependencies for development and CI environments as described in CONTRIBUTING.md.
[project.optional-dependencies]
preql = ["preql>=0.2.19"]
mysql = ["mysql-connector-python>=8.0.29"]
postgresql = ["psycopg2"]
redshift = ["psycopg2"]
snowflake = ["snowflake-connector-python>=3.0.2,<4.0.0", "cryptography"]
presto = ["presto-python-client"]
oracle = ["oracledb"]
mssql = ["pyodbc>=4.0.39"]
trino = ["trino>=0.314.0"]
clickhouse = ["clickhouse-driver"]
vertica = ["vertica-python"]
duckdb = ["duckdb"]
all-dbs = [
"preql>=0.2.19",
"mysql-connector-python>=8.0.29",
"psycopg2",
"snowflake-connector-python>=3.0.2,<4.0.0",
"cryptography",
"presto-python-client",
"oracledb",
"pyodbc>=4.0.39",
"trino>=0.314.0",
"clickhouse-driver",
"vertica-python",
"duckdb",
]
dev = [
"parameterized",
"unittest-parallel",
"ruff>=0.1.4",
"pre-commit>=3.5.0",
]
ci = [
"google-cloud-bigquery<3.0.0",
]
[project.scripts]
data-diff = "data_diff.__main__:main"
[project.urls]
Repository = "https://github.com/GannettDigital/data-diff"
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
| Pip Install Without Pinned Package Version | Dockerfile | View in code |
☢️ The following Vulnerabilities (CVEs) have been detected
| PACKAGE | FILE | CVE ID | INSTALLED VERSION | FIXED VERSION | ||
|---|---|---|---|---|---|---|
| mysql-connector-python | ./uv.lock | CVE-2024-21272 | 8.0.29 | 9.1.0 | View in code | |
| orjson | ./uv.lock | CVE-2025-67221 | 3.11.5 | 3.11.6 | View in code | |
| pyopenssl | ./uv.lock | CVE-2026-27459 | 25.3.0 | 26.0.0 | View in code | |
| urllib3 | ./uv.lock | CVE-2025-66418 | 1.26.20 | 2.6.0 | View in code | |
| urllib3 | ./uv.lock | CVE-2025-66471 | 1.26.20 | 2.6.0 | View in code | |
| urllib3 | ./uv.lock | CVE-2026-21441 | 1.26.20 | 2.6.3 | View in code |
Note: The scan should have failed if no policies were configured in warn-only mode.
Migrate project tooling from Poetry to uv
Fixes #35
Purpose
Switch the project from Poetry to
uvto speed up local environment setup and CI, and to reduce Poetry-specific packaging and workflow configuration.Scope
pyproject.tomltoward standard project metadata and dependency groupsuvequivalentsAcceptance Criteria
uvuv