fix: restore vitest 4 mock isolation + drop EOL Node 18#25
Merged
Conversation
vitest 4 changed restoreAllMocks() to no longer reset vi.fn() call history (only restores spies), causing mock call counts to accumulate across tests. Enable clearMocks to restore per-test isolation.
📝 WalkthroughWalkthroughThis PR enables Vitest's automatic mock clearing by adding ChangesVitest Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
vitest 4 uses node:util styleText, available only on Node 20.12+. Node 18 reached end-of-life in April 2025. Bump engines and CI matrix to Node 20/22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vitest 4 (merged in #24, the critical GHSA-5xrq-8626-4rwp fix) introduced two breakages on
main:vi.restoreAllMocks()to only restorevi.spyOnmocks, no longer resettingvi.fn()call history. The testbeforeEachblocks relied on it, so call counts accumulated and 9 tests failed. Fixed withclearMocks: truein vitest config.node:utilstyleText(Node 20.12+ only). Node 18 is EOL (Apr 2025). Dropped Node 18 from the CI matrix and bumpedenginesto>=20.Test plan
npx vitest run-> 96/96 pass locally