Skip to content

Fix: Prevent use-after-free in HTTPRequest completion callback #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Prevent use-after-free in HTTPRequest completion callback #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion GeneralsMD/Code/GameEngine/Source/GameNetwork/GeneralsOnline/HTTP/HTTPRequest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ void HTTPRequest::InvokeCallbackIfComplete()
{
if (m_completionCallback != nullptr)
{
// Move the callback into a local variable and clear the member before
// invoking it. This prevents a use-after-free: the HTTPRequest may be
// deleted (by HTTPManager::Tick) immediately after this call returns,
// which would run ~HTTPRequest and destroy m_completionCallback's
// captured state while it is still on the call stack.
auto callback = std::move(m_completionCallback);
m_completionCallback = nullptr;

// Convert m_vecBuffer to std::string for m_strResponse
std::string strResponse;
if (!m_vecBuffer.empty() && m_currentBufSize_Used > 0)
Expand All @@ -110,7 +118,7 @@ void HTTPRequest::InvokeCallbackIfComplete()
{
strResponse.clear();
}
m_completionCallback(true, m_responseCode, strResponse, this);
callback(true, m_responseCode, strResponse, this);
}
}
}
Expand Down
Loading