Skip to content

Fix crash with empty lobby name #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x64-dev merged 1 commit into from
Mar 20, 2026
Merged

Fix crash with empty lobby name #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/PopupHostGame.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,16 +596,10 @@ WindowMsgHandledType PopupHostGameSystem( GameWindow *window, UnsignedInt msg, W
name.trim();
if(name.isEmpty())
{
NGMP_OnlineServices_AuthInterface* pAuthInterface = NGMP_OnlineServicesManager::GetInterface<NGMP_OnlineServices_AuthInterface>();
if (pAuthInterface != nullptr)
{
name.format(L"%s", pAuthInterface->GetDisplayName());
GadgetTextEntrySetText(textEntryGameName, name);
}
else
{
name = L"Generals Online Lobby";
}
SetLobbyAttemptHostJoin(FALSE);
GameSpyCloseOverlay(GSOVERLAY_GAMEOPTIONS);
GSMessageBoxOk(TheGameText->fetch("GUI:Error"), UnicodeString(L"Please enter a lobby name."), nullptr);
break;
}
#if defined(GENERALS_ONLINE)
// save last used lobby name to CustomPref.ini
Expand Down
Loading