Skip to content

Fix: Prevent out-of-bounds LOD access in HLOD rendering#399

Open
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/hlod-lod-bounds
Open

Fix: Prevent out-of-bounds LOD access in HLOD rendering#399
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/hlod-lod-bounds

Conversation

@seer-by-sentry
Copy link

Fixes CLIENT-43X. The issue was that: HLodClass::Render read access violation occurs due to concurrent modification of Lod array and LodCount by another thread.

  • Implemented robust bounds checking for the LOD index (CurLod) in HLODClass::Render.
  • If the current LOD index is out of range, it now defaults to the highest detail LOD (LodCount - 1).
  • Applied the same bounds checking logic to HLODClass::Special_Render to ensure safe array access.
  • Prevents potential crashes or undefined behavior due to invalid LOD indices.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 12143998

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants