Skip to content

Fix(drawable): Prevent crash with null custom ambient sound info during save #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(drawable): Prevent crash with null custom ambient sound info during save #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions GeneralsMD/Code/GameEngine/Source/GameClient/Drawable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5405,9 +5405,19 @@ void Drawable::xfer(Xfer* xfer)
{
if (!customizedToSilence)
{
AsciiString baseInfoName = m_customSoundAmbientInfo->getOriginalName();
xfer->xferAsciiString(&baseInfoName);
m_customSoundAmbientInfo->xferNoName(xfer);
// Guard against dangling or invalid pointer before dereferencing
if (m_customSoundAmbientInfo != NULL)
{
AsciiString baseInfoName = m_customSoundAmbientInfo->getOriginalName();
xfer->xferAsciiString(&baseInfoName);
m_customSoundAmbientInfo->xferNoName(xfer);
}
else
{
DEBUG_CRASH(("Drawable::xfer - m_customSoundAmbientInfo is NULL during save but customized flag is set; skipping custom ambient sound save"));
AsciiString emptyName;
xfer->xferAsciiString(&emptyName);
}
}
}
}
Expand Down
Loading