Skip to content

pstext -D[j|J] is broken#8921

Open
Chuan1937 wants to merge 2 commits intoGenericMappingTools:masterfrom
Chuan1937:fix
Open

pstext -D[j|J] is broken#8921
Chuan1937 wants to merge 2 commits intoGenericMappingTools:masterfrom
Chuan1937:fix

Conversation

@Chuan1937
Copy link
Member

@Chuan1937 Chuan1937 commented Mar 12, 2026

Add additional check for MC position in gmt_support.

Fixes: #8712
Refixing: #8916

The local test was successful:

The following tests passed:
        doc/scripts/GMT_pstext_clearance.sh
        doc/scripts/GMT_pstext_justify.sh
        test/pstext/ISO-8859-2.sh
        test/pstext/book.sh
        test/pstext/boxtext.sh
        test/pstext/caption.sh
        test/pstext/cliptxtbox.sh
        test/pstext/composite.sh
        test/pstext/corner_justify.sh
        test/pstext/delay.sh
        test/pstext/escape.sh
        test/pstext/filled_font.sh
        test/pstext/labeler.sh
        test/pstext/para_offset.sh
        test/pstext/pstext-l2s.sh
        test/pstext/shade_text.sh
        test/pstext/supersub.sh
        test/pstext/textclip.sh
        test/pstext/utf8.sh

100% tests passed, 0 tests failed out of 19

Total Test time (real) =  16.27 sec

@Chuan1937 Chuan1937 changed the title add additional check for MC position in gmt_support pstext -D[j|J] is broken Mar 12, 2026
@Chuan1937 Chuan1937 requested a review from joa-quim March 12, 2026 13:08
@Chuan1937 Chuan1937 added the bug Something isn't working label Mar 12, 2026
@Chuan1937 Chuan1937 added this to the 6.7.0 milestone Mar 12, 2026
@Chuan1937 Chuan1937 self-assigned this Mar 12, 2026
@joa-quim
Copy link
Member

I still have local failures that seem to be related to this. For example,

        799 - test/psbasemap/radial_labels1.sh (Failed)
        800 - test/psbasemap/radial_labels2.sh (Failed)
        801 - test/psbasemap/radial_labels3.sh (Failed)

They fail because text strings are a bit out of place when compared with references.

@Chuan1937
Copy link
Member Author

I still have local failures that seem to be related to this. For example,

        799 - test/psbasemap/radial_labels1.sh (Failed)
        800 - test/psbasemap/radial_labels2.sh (Failed)
        801 - test/psbasemap/radial_labels3.sh (Failed)

They fail because text strings are a bit out of place when compared with references.

Need to run all the tests, right. I've only run examples related to pstext before. So there are omissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pstext -D[j|J] is broken

2 participants