build_arg_list: Raise an exception if an invalid output file name is given#3336
Merged
build_arg_list: Raise an exception if an invalid output file name is given#3336
Conversation
weiji14
approved these changes
Jul 19, 2024
Member
weiji14
left a comment
There was a problem hiding this comment.
Looks ok I think, just one suggestion to check the Windows-style folders ending with \\.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Member
Author
|
/format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
When working on PR #3334, I realized that we didn't check if the
outfileparameter passed tobuild_arg_listis valid or not. Some invalid values are"",".",".."or a string ending with/or\.This PR enhances the
build_arg_listfunction to check if theoutfileargument is valid. We can't check all cases but at least we can raise an exception for a few common cases.This PR will further simplify #3334.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code