Conversation
|
pre-commit.ci run |
seisman
added
maintenance
| - id: chmod | ||
| args: ['644'] |
There was a problem hiding this comment.
You can add a exclude: .pre-commit-config.yaml line to exclude 644 permissions on this file if I'm not mistaken. See https://pre-commit.com/#config-exclude
There was a problem hiding this comment.
Oh wait sorry, I misread things. Let me see if there's another way...
There was a problem hiding this comment.
Since we only care about if files have execute permission, so I thought chmod -x should work. Unfortunately the hook doesn't support it yet https://github.com/Lucas-C/pre-commit-hooks/blob/a30f0d816e5062a67d87c8de753cfe499672b959/pre_commit_hooks/chmod.py#L35-L40.
There was a problem hiding this comment.
Maybe we skip the chmod hook on pre-commit.ci using https://pre-commit.ci/#configuration-skip? Since we have the check on the `Style Checks' CI already on GitHub Actions and it doesn't complain there.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
…e Checks workflow" This reverts commit d858f77.
seisman
changed the title
2 participants
Address #3414 (comment).
Patches #3414.