CI: Remove the pytest-xdist plugin from the "Tests" and "Dev Tests" workflows#3627
Merged
CI: Remove the pytest-xdist plugin from the "Tests" and "Dev Tests" workflows#3627
Conversation
seisman
changed the title
seisman
force-pushed
the
to_numpy/skip-macos
branch
from
29cffe5 to
1ff03a3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
seisman
force-pushed
the
to_numpy/skip-macos
branch
7 times, most recently
from
9a10d9e to
2666531
Compare
seisman
changed the title
seisman
force-pushed
the
to_numpy/skip-macos
branch
from
555d1c1 to
d0bad08
Compare
seisman
force-pushed
the
to_numpy/skip-macos
branch
2 times, most recently
from
a3838f6 to
b83c2c1
Compare
seisman
force-pushed
the
to_numpy/skip-macos
branch
from
cfc9ec7 to
7d3ed8b
Compare
seisman
changed the title
seisman
added
maintenance
weiji14
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS CI jobs recently started failing, as originally reported in #3601 (comment). After investigating, I identified commit f91475d as the first commit causing the issue. However, reverting this commit alone does not fully resolve the failures, as subsequent commits related to testing the
_to_numpyfunction also contribute to the problem.The exact reason why commit f91475d triggers these failures (on macOS only) remains unclear. However, removing the
pytest-xdistplugin, which runs tests across multiple processes, resolves the failures, allowing the CI jobs to pass successfully again.The downside of this fix is that removing
pytest-xdistincreases the CI runtime, as tests now run sequentially instead of in parallel. While this trade-off impacts efficiency, it ensures stability for the macOS CI jobs.