CI: Pin to sphinx>=6.2 for docs build on Python 3.13#3667
Merged
Conversation
Fix `ModuleNotFoundError: No module named 'imghdr'` on Python 3.13. Xref sphinx-doc/sphinx#10440 (comment)
Member
|
I'm a little surprise to see that the CI is still using sphinx 5.x even though the latest version is sphinx 8.x. |
Member
|
We also need to update the Line 174 in 7845e9e |
seisman
approved these changes
Dec 3, 2024
seisman
pushed a commit
that referenced
this pull request
Dec 3, 2024
Fix `ModuleNotFoundError: No module named 'imghdr'` on Python 3.13. Xref sphinx-doc/sphinx#10440 (comment) * Set needs_sphinx to 6.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fix
ModuleNotFoundError: No module named 'imghdr'on Python 3.13. Xref sphinx-doc/sphinx#10440 (comment)Full traceback from https://readthedocs.org/projects/pygmt-dev/builds/26462203/ in #3490:
Helps with #3490
Preview:
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code