Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jan 11, 2026

With the new Figure.scalebar method, we can deprecate the map_scale parameter in Figure.basemap/Figure.coast.

Please note that map_scale is only marked as deprecated in the docstrings, no warning will be raised.

Preview:

@seisman seisman added this to the 0.19.0 milestone Jan 11, 2026
@seisman seisman added the deprecation Deprecating a feature label Jan 11, 2026
@seisman seisman changed the title Figure.basemap/Figure.coast: Deprecate the 'map_scale' parameter. Use 'Figure.scalebar' instead Figure.basemap/Figure.coast: Recommend to use the Figure.scalebar method to add a scalebar Jan 19, 2026
Base automatically changed from feature/scalebar to main January 21, 2026 02:48
@seisman seisman marked this pull request as ready for review January 21, 2026 03:03
@seisman seisman merged commit b024edd into main Jan 21, 2026
23 checks passed
@seisman seisman deleted the basemap/map_scale branch January 21, 2026 10:46
@seisman seisman added the documentation Improvements or additions to documentation label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants