Upgrade of setuptools with fixes to dependencies#14330
Conversation
giohappy
changed the title
giohappy
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependency versions in pyproject.toml, including django-downloadview, django-polymorphic, geonode-pinax-notifications, geonode-oauth-toolkit, and setuptools. Feedback is provided regarding the setuptools dependency constraint, pointing out that removing the lower bound could allow incompatible older versions to be installed, and noting that the adjacent comment is now outdated and should be updated.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # importer dependencies | ||
| # blocked to <80 to avoid warning during the runtime for with py312 related to the polymorphic model | ||
| "setuptools>=59,<80", | ||
| "setuptools<83", |
There was a problem hiding this comment.
The comment on line 111 is now outdated and contradicts the new constraint of <83. Please update or remove the comment to reflect this change.
Additionally, removing the lower bound (>=59) might allow older, incompatible versions of setuptools to be installed at runtime. It is recommended to retain a lower bound of >=61.0 to align with the build-system requirement.
| "setuptools<83", | |
| "setuptools>=61.0,<83", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14330 +/- ##
===========================================
+ Coverage 34.71% 53.09% +18.38%
===========================================
Files 982 982
Lines 60496 60527 +31
Branches 8247 8252 +5
===========================================
+ Hits 21002 32139 +11137
+ Misses 38332 26906 -11426
- Partials 1162 1482 +320 🚀 New features to boost your workflow:
|
|
Let's wait for #14339 then we will run the tests again |
1 participant
No description provided.