Removing danglish js/html files that are not actually used to do anything#1477
Open
aaime wants to merge 1 commit intoGeoWebCache:mainfrom
Open
Removing danglish js/html files that are not actually used to do anything#1477aaime wants to merge 1 commit intoGeoWebCache:mainfrom
aaime wants to merge 1 commit intoGeoWebCache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes unused OpenLayers 3 web resource files that appear to be incomplete work from 12 years ago. The files being deleted include WMTS and WMS JavaScript implementations along with their HTML pages, plus a minified jQuery library.
Changes:
- Deletion of unused OpenLayers 3 WMTS implementation files
- Deletion of unused OpenLayers 3 WMS implementation files
- Removal of bundled jQuery 1.11.1 library
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| geowebcache/core/src/main/resources/org/geowebcache/rest/webresources/openlayers3/wmts.js | Removes incomplete WMTS JavaScript implementation for OpenLayers 3 |
| geowebcache/core/src/main/resources/org/geowebcache/rest/webresources/openlayers3/wmts.html | Removes HTML page for WMTS OpenLayers 3 demo |
| geowebcache/core/src/main/resources/org/geowebcache/rest/webresources/openlayers3/wms.js | Removes incomplete WMS JavaScript implementation for OpenLayers 3 |
| geowebcache/core/src/main/resources/org/geowebcache/rest/webresources/openlayers3/wms.html | Removes HTML page for WMS OpenLayers 3 demo |
| geowebcache/core/src/main/resources/org/geowebcache/rest/webresources/openlayers3/jquery-1.11.1.min.js | Removes bundled jQuery 1.11.1 minified library |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probabably a work in progress that never got completed, from 12 years ago