Skip to content

fix: audio attachment style edge cases #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isekovanic merged 1 commit into from
Jun 12, 2026
+12 −9
Merged

fix: audio attachment style edge cases #3646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions package/src/components/Attachment/Attachment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,16 +224,17 @@ const useAudioAttachmentStyles = () => {
const messageHasSingleAttachment = message.attachments?.length === 1;
const messageHasCaption = !!message.text?.trim();
const messageIsQuotedReply = !!(message.quoted_message || message.quoted_message_id);
const shouldRemoveAudioAttachmentPadding =
messageIsQuotedReply && messageHasSingleAttachment && !messageHasCaption;
const showBackgroundTransparent =
messageHasOnlySingleAttachment ||
(messageIsQuotedReply && messageHasSingleAttachment && !messageHasCaption);
messageHasOnlySingleAttachment || shouldRemoveAudioAttachmentPadding;

return useMemo(() => {
return StyleSheet.create({
container: {
paddingVertical: primitives.spacingXs,
paddingLeft: primitives.spacingXs,
paddingRight: primitives.spacingSm,
paddingLeft: shouldRemoveAudioAttachmentPadding ? 0 : primitives.spacingXs,
paddingRight: shouldRemoveAudioAttachmentPadding ? 0 : primitives.spacingSm,
borderWidth: 0,
backgroundColor: showBackgroundTransparent
? 'transparent'
Expand All @@ -255,6 +256,9 @@ const useAudioAttachmentStyles = () => {
color: semantics.chatTextIncoming,
fontWeight: primitives.typographyFontWeightSemiBold,
},
leftContainer: {
padding: shouldRemoveAudioAttachmentPadding ? 0 : primitives.spacingXxs,
},
});
}, [semantics, isMyMessage, showBackgroundTransparent]);
}, [shouldRemoveAudioAttachmentPadding, showBackgroundTransparent, isMyMessage, semantics]);
};
7 changes: 3 additions & 4 deletions package/src/components/Attachment/Audio/AudioAttachment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export type AudioAttachmentProps = {
playPauseButton?: StyleProp<ViewStyle>;
speedSettingsButton?: StyleProp<ViewStyle>;
durationText?: StyleProp<TextStyle>;
leftContainer?: StyleProp<TextStyle>;
};
};

Expand Down Expand Up @@ -215,7 +216,7 @@ export const AudioAttachment = (props: AudioAttachmentProps) => {
style={[styles.container, container, containerStyle, stylesProps?.container]}
testID={testID}
>
<View style={[styles.leftContainer, leftContainer]}>
<View style={[styles.leftContainer, stylesProps?.leftContainer, leftContainer]}>
<PlayPauseButton
isPlaying={isPlaying}
accessibilityLabel='Play Pause Button'
Expand Down Expand Up @@ -341,9 +342,7 @@ const useStyles = () => {
fontWeight: primitives.typographyFontWeightSemiBold,
lineHeight: primitives.typographyLineHeightTight,
},
leftContainer: {
padding: primitives.spacingXxs,
},
leftContainer: {},
progressControlContainer: {
flex: 1,
},
Expand Down