Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/SampleApp/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ PODS:
- nanopb/encode (= 3.30910.0)
- nanopb/decode (3.30910.0)
- nanopb/encode (3.30910.0)
- NitroModules (0.35.9):
- NitroModules (0.31.3):
- hermes-engine
- RCTRequired
- RCTTypeSafety
Expand All @@ -207,7 +207,7 @@ PODS:
- ReactCommon/turbomodule/core
- ReactNativeDependencies
- Yoga
- NitroSound (0.2.15):
- NitroSound (0.2.9):
- hermes-engine
- NitroModules
- RCTRequired
Expand Down Expand Up @@ -3232,8 +3232,8 @@ SPEC CHECKSUMS:
libdav1d: 23581a4d8ec811ff171ed5e2e05cd27bad64c39f
libwebp: 02b23773aedb6ff1fd38cec7a77b81414c6842a8
nanopb: fad817b59e0457d11a5dfbde799381cd727c1275
NitroModules: fa3f01c46ec724812c2a1a7074eeb528980f6a47
NitroSound: 90d19ad981456113476388338d5b6b2a7d58999d
NitroModules: e2c4f7166ca860e21959433f70818e97be498b88
NitroSound: cb3c7c6b9d9d4329cc0fed7e566bb58842a1f895
op-sqlite: 8e86ae95b132eb4364492e44e848a5272f3ca582
PromisesObjC: f5707f49cb48b9636751c5b2e7d227e43fba9f47
PromisesSwift: 9d77319bbe72ebf6d872900551f7eeba9bce2851
Expand Down
4 changes: 2 additions & 2 deletions examples/SampleApp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
"react-native-haptic-feedback": "^3.0.0",
"react-native-image-picker": "^8.2.1",
"react-native-maps": "^1.27.2",
"react-native-nitro-modules": "^0.35.9",
"react-native-nitro-sound": "^0.2.15",
"react-native-nitro-modules": "0.31.3",
"react-native-nitro-sound": "0.2.9",
"react-native-reanimated": "4.3.1",
"react-native-safe-area-context": "^5.8.0",
"react-native-screens": "^4.25.2",
Expand Down
14 changes: 0 additions & 14 deletions package/native-package/src/optionalDependencies/Audio.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,6 @@ class _Audio {
audioSet: {
// Android specific properties
AudioEncoderAndroid: AudioEncoderAndroidType.AAC,
// Pin nitro-sound 0.2.10+'s bitrate to 128 kbps. Its `.high` quality
// preset otherwise defaults to (48 kHz, 2ch, 192 kbps), a combination
// the iOS hardware AAC encoder rejects with
// kAudioFormatUnsupportedDataFormatError ('fmt?', OSStatus 1718449215)
// in AppStore signed binaries.
// https://www.osstatus.com/search/results?search=1718449215
// Older nitro-sound and the legacy `react-native-audio-recorder-player`
// ignore this key.
AudioEncodingBitRate: 128000,
AudioSourceAndroid: AudioSourceAndroidType.MIC,
OutputFormatAndroid: OutputFormatAndroidType.AAC_ADTS,

Expand All @@ -130,11 +121,6 @@ class _Audio {
? AVModeIOSOptionNitroSound.spokenaudio
: AVModeIOSOption.spokenaudio,
AVNumberOfChannelsKeyIOS: 2,
// Pair with `AudioEncodingBitRate` above override nitro-sound 0.2.10+'s
// 48 kHz default back to 44.1 kHz so the encoder gets the combo that
// 0.2.9 was implicitly using. Idempotent for older nitro-sound and the
// legacy lib (their default is already 44.1 kHz).
AVSampleRateKeyIOS: 44100,
},
isMeteringEnabled: true,
},
Expand Down
9 changes: 0 additions & 9 deletions package/src/types/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -501,15 +501,6 @@ type AVEncodingType =
export interface AudioSet {
AudioChannelsAndroid?: number;
AudioEncoderAndroid?: AudioEncoderAndroidType;
/**
* Cross-platform bitrate hint introduced in `react-native-nitro-sound` 0.2.10+.
* Sits alongside the iOS-native `AVEncoderBitRateKeyIOS` because nitro-sound
* reads `AudioEncodingBitRate` on iOS (mapping it to `AVEncoderBitRateKey`),
* not the platform-specific key. Older nitro-sound builds and the legacy
* `react-native-audio-recorder-player` ignore this field, so it's safe to
* include unconditionally.
*/
AudioEncodingBitRate?: number;
AudioEncodingBitRateAndroid?: number;
AudioSamplingRateAndroid?: number;
AudioSourceAndroid?: AudioSourceAndroidType;
Expand Down
26 changes: 13 additions & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5420,7 +5420,7 @@ __metadata:
languageName: node
linkType: hard

"@react-native-community/slider@npm:^5.2.0":
"@react-native-community/slider@npm:^5.0.1":
version: 5.2.0
resolution: "@react-native-community/slider@npm:5.2.0"
checksum: 10c0/58ec6a47b5aafefd98a61c79aeae05f1ab8371782eb497d9af665bf2f62a1c372da8fed6dead30e1d6c9e01bfb12bfdbafcde7890736f4f5d55502dabf2e01ad
Expand Down Expand Up @@ -17872,26 +17872,26 @@ __metadata:
languageName: node
linkType: hard

"react-native-nitro-modules@npm:^0.35.9":
version: 0.35.9
resolution: "react-native-nitro-modules@npm:0.35.9"
"react-native-nitro-modules@npm:0.31.3":
version: 0.31.3
resolution: "react-native-nitro-modules@npm:0.31.3"
peerDependencies:
react: "*"
react-native: "*"
checksum: 10c0/2e5c1b3eed1d187e7c2bbbf661e6405cb69c6a20b01427ea4c8a3bfe07a4baf2efbeb170a21f8c17fb0e18f022244f4b1fe1ce69a7ec824a7a4cf72441893cf1
checksum: 10c0/ec37750c9ae0a1c433c307cfba78474cb1c2593f6b4780d00250755688ed049602e28fa3c4e2b9f922a815353b6ed8c74db580973e736a4d8aba4f06eed7c91b
languageName: node
linkType: hard

"react-native-nitro-sound@npm:^0.2.15":
version: 0.2.15
resolution: "react-native-nitro-sound@npm:0.2.15"
"react-native-nitro-sound@npm:0.2.9":
version: 0.2.9
resolution: "react-native-nitro-sound@npm:0.2.9"
dependencies:
"@react-native-community/slider": "npm:^5.2.0"
"@react-native-community/slider": "npm:^5.0.1"
peerDependencies:
react: "*"
react-native: "*"
react-native-nitro-modules: ">=0.35.4"
checksum: 10c0/215624ccc6303475ee21ac734b40bcddb9bf8ad8996a3ea8af3c98d507280261686f8d7289a5eac56736ad33c0e20395fb843d78c5441c58f79f70086c5759fe
react-native-nitro-modules: "*"
checksum: 10c0/10fdb135ef226b0de845ae91d4cfb88fec8a55ee5350919b8005589fa08750b934c76b5ccd0265ae38e7d9aa14b28f83d156d3d3582cfef15e9b9f93873a2505
languageName: node
linkType: hard

Expand Down Expand Up @@ -18874,8 +18874,8 @@ __metadata:
react-native-haptic-feedback: "npm:^3.0.0"
react-native-image-picker: "npm:^8.2.1"
react-native-maps: "npm:^1.27.2"
react-native-nitro-modules: "npm:^0.35.9"
react-native-nitro-sound: "npm:^0.2.15"
react-native-nitro-modules: "npm:0.31.3"
react-native-nitro-sound: "npm:0.2.9"
react-native-reanimated: "npm:4.3.1"
react-native-safe-area-context: "npm:^5.8.0"
react-native-screens: "npm:^4.25.2"
Expand Down