fix: install dev deps before build in Dockerfile.prod#247
fix: install dev deps before build in Dockerfile.prod#247ChaitanyaChute wants to merge 1 commit into
Conversation
✅ Deploy Preview for github-spy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe production Dockerfile build stage now installs full npm dependencies including dev tools before copying the application source and running the build, fixing a bug where build commands failed due to missing development dependencies. ChangesProduction Docker Build Configuration
🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🎉 Thank you @ChaitanyaChute for your contribution. Please make sure your PR follows https://github.com/GitMetricsLab/github_tracker/blob/main/CONTRIBUTING.md#-pull-request-guidelines
Related Issue
Description
Fix the production Docker build by installing all dependencies before running
npm run buildinDockerfile.prod. This ensures dev-only build tools (like Vite) are available during the build stage.How Has This Been Tested?
docker build -f Dockerfile.prod .Type of Change
Summary by CodeRabbit