fix: correct post-login redirect route#250
Conversation
✅ Deploy Preview for github-spy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughSmall targeted updates to authentication flows: added debug logging in signup to diagnose backend URL resolution, corrected post-login navigation route from "/home" to "/", and cleaned environment configuration examples by removing obsolete sample entries. ChangesAuthentication Flow Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thank you @Kannu20 for your contribution. Please make sure your PR follows https://github.com/GitMetricsLab/github_tracker/blob/main/CONTRIBUTING.md#-pull-request-guidelines
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/pages/Signup/Signup.tsx (1)
27-28: ⚡ Quick winRemove debug logging before production.
These console.log statements were added to diagnose the undefined backend URL issue, but they should not remain in production code. Instead, add validation to ensure
backendUrlis defined before making the API request.♻️ Proposed refactor to replace debug logs with validation
- console.log("backendUrl:", backendUrl); -console.log("env:", import.meta.env.VITE_BACKEND_URL); + if (!backendUrl) { + setMessage("Configuration error: Backend URL is not defined."); + return; + }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/Signup/Signup.tsx` around lines 27 - 28, Remove the stray console.log debug lines and add validation around the backend URL used for API calls: ensure the value referenced as backendUrl (and if applicable import.meta.env.VITE_BACKEND_URL) is defined and non-empty before performing the request (e.g., in the Signup component or the function that calls fetch/axios), and surface a clear user-facing error or throw a descriptive error/log via processLogger/ui state instead of logging to console; fail-fast so the API call is not attempted when backendUrl is missing.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/Login/Login.tsx`:
- Line 37: The PR description incorrectly states the login redirect goes to
"/home" while the code in Login.tsx calls navigate("/") (which routes to the
Home page); update the PR description to state the redirect is to "/" (matching
navigate("/") in Login.tsx and the defined route in Router.tsx) so the PR text
accurately reflects the implementation.
---
Nitpick comments:
In `@src/pages/Signup/Signup.tsx`:
- Around line 27-28: Remove the stray console.log debug lines and add validation
around the backend URL used for API calls: ensure the value referenced as
backendUrl (and if applicable import.meta.env.VITE_BACKEND_URL) is defined and
non-empty before performing the request (e.g., in the Signup component or the
function that calls fetch/axios), and surface a clear user-facing error or throw
a descriptive error/log via processLogger/ui state instead of logging to
console; fail-fast so the API call is not attempted when backendUrl is missing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5833bd4e-af06-4d41-8111-0f5c4f60c975
📒 Files selected for processing (4)
.env.examplebackend/.env.samplesrc/pages/Login/Login.tsxsrc/pages/Signup/Signup.tsx
💤 Files with no reviewable changes (2)
- backend/.env.sample
- .env.example
|
|
||
| if (response.data.message === 'Login successful') { | ||
| navigate("/home"); | ||
| navigate("/"); |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find route definitions to verify the correct post-login destination.
# Search for route definitions in the codebase
rg -n --type=tsx --type=ts -A 3 -B 3 'path.*["\']/(home)?' --glob '!node_modules'Repository: GitMetricsLab/github_tracker
Length of output: 241
🏁 Script executed:
#!/bin/bash
# Search for route definitions and the root path handler
fd -e tsx -e ts | head -20Repository: GitMetricsLab/github_tracker
Length of output: 629
🏁 Script executed:
#!/bin/bash
# Look for Router/Routes configuration
rg -n "path|Route" --type tsx --type ts -A 2 | head -40Repository: GitMetricsLab/github_tracker
Length of output: 100
🏁 Script executed:
#!/bin/bash
# Check the App component to see routing setup
fd "App\\.tsx" -o "app\\.tsx" -o "index\\.tsx" | grep -E "(App|app|index)" | head -10Repository: GitMetricsLab/github_tracker
Length of output: 208
🏁 Script executed:
cat -n src/Routes/Router.tsxRepository: GitMetricsLab/github_tracker
Length of output: 1271
🏁 Script executed:
cat -n src/App.tsxRepository: GitMetricsLab/github_tracker
Length of output: 1513
🏁 Script executed:
sed -n '30,45p' src/pages/Login/Login.tsxRepository: GitMetricsLab/github_tracker
Length of output: 478
Correct the PR description to match the code.
The code correctly navigates to "/" (which displays the Home page), but the PR description incorrectly states the redirect is to "/home". There is no /home route defined in the application—only / (line 14 of src/Routes/Router.tsx). Update the PR description to accurately reflect that the redirect is to "/", not "/home".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/pages/Login/Login.tsx` at line 37, The PR description incorrectly states
the login redirect goes to "/home" while the code in Login.tsx calls
navigate("/") (which routes to the Home page); update the PR description to
state the redirect is to "/" (matching navigate("/") in Login.tsx and the
defined route in Router.tsx) so the PR text accurately reflects the
implementation.
1 participant
Related Issue
Closes #244
Description
Fixed authentication API request failures caused by an undefined backend URL.
Changes made:
/homeHow Has This Been Tested?
Type of Change
Summary by CodeRabbit