This repository was archived by the owner on Dec 7, 2022. It is now read-only.
adds selectors to the Audit results#305
Open
philschatz wants to merge 1 commit intoGoogleChrome:masterfrom
Open
adds selectors to the Audit results#305philschatz wants to merge 1 commit intoGoogleChrome:masterfrom
philschatz wants to merge 1 commit intoGoogleChrome:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an additional field to the Audit results object which provides an array of selectors that were found. I added it as an additional field to maintain backwards-compatibility with previous versions.
Some use-cases for adding selectors:
inspect(...)an element when clickedQuestions
getQuerySelectorText(element)does not always generate a valid selector, should it be configured in theAuditConfigvia something likeconfig.includeSelectors = true?