fix: Clean up leaked progress bars on session stop#186
Open
ajma wants to merge 1 commit intoGoogleCloudDataproc:mainfrom
Open
fix: Clean up leaked progress bars on session stop#186ajma wants to merge 1 commit intoGoogleCloudDataproc:mainfrom
ajma wants to merge 1 commit intoGoogleCloudDataproc:mainfrom
Conversation
_execution_progress_bar entries are only removed when operations complete with done=True. If operations are interrupted or fail before the handler is called with done=True, their tqdm objects leak. Now clears all remaining progress bars during stop().
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a cleanup mechanism for progress bars within the stop method of DataprocSparkSession to ensure resources are released during session termination. The review feedback suggests optimizing this by moving the progress bar closure logic outside of the global lock to reduce potential thread contention and improve performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_execution_progress_bar entries are only removed when operations complete with done=True. If operations are interrupted or fail before the handler is called with done=True, their tqdm objects leak. Now clears all remaining progress bars during stop().