Update image-server configuration environment variable names.#150
Open
manuskc wants to merge 1 commit into
Open
Update image-server configuration environment variable names.#150manuskc wants to merge 1 commit into
manuskc wants to merge 1 commit into
Conversation
| IMAGES_SERVICE_ENDPOINT = 'APPENGINE_IMAGES_SERVICE_ENDPOINT' | ||
|
|
||
|
|
||
| _USE_GRPC = bool(os.environ.get(USE_CUSTOM_IMAGES_GRPC_SERVICE)) |
Collaborator
There was a problem hiding this comment.
Looks like I found a pre-existing bug:
In Python, bool() evaluates to True for any non-empty string. If a developer explicitly tries to disable the service by setting APPENGINE_USE_CUSTOM_IMAGES_GRPC_SERVICE: "false" or "0" in their app.yaml, it will be incorrectly evaluated as True.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update image-server environment variable names to align with the standard naming conventions used across other bundled services.
Testing done: