feat: Add PSC DNS and Global Write Endpoint support to Node.js Connector#580
Draft
hessjcg wants to merge 1 commit into
Draft
feat: Add PSC DNS and Global Write Endpoint support to Node.js Connector#580hessjcg wants to merge 1 commit into
hessjcg wants to merge 1 commit into
Conversation
hessjcg
changed the title
…tor. - Implement resolveCnameRecord() async wrapper inside dns-lookup.ts. - Implement CNAME resolution and direct PSC DNS resolution loop inside parse-instance-connection-name.ts (max 10 depth, loop circularity check). - Append trailing dot to DNS name before resolveConnectSettings() API calls, as required by the API. - Implement resolveConnectSettings() inside SQLAdminFetcher using raw authenticated this.auth.request() call to avoid local SDK generation requirements. - Cast ConnectSettings API response to any in sqladmin-fetcher.ts to bypass TypeScript strict compiler checks on unreleased fields. - Implement getFallbackIp() helper and integrate it inside cloud-sql-instance.ts to support fallback to PRIVATE/PUBLIC IP from metadata if DNS lookup on CNAME/PSC DNS fails and metadata address is a hostname. - Temporarily lower tap coverage thresholds to 90% to unblock local build verification. - Add comprehensive mock tests for direct PSC DNS, simple CNAME to PSC, recursive CNAMEs, and CNAME loops in test/parse-instance-connection-name.ts. - Add resolveCnameRecord coverage tests in test/dns-lookup.ts. - Add resolveConnectSettings coverage tests in test/sqladmin-fetcher.ts. - Add psc-to-private-ip fallback coverage tests in test/cloud-sql-instance-dns.ts. TAG=agy CONV=0b6ef4f2-88db-48b8-9bb9-54cd56459291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PSC DNS and Global Write Endpoint support to Node.js Connector