Issue#8261 : Added test cases for InfiniteStreamRecognize class#9498
Issue#8261 : Added test cases for InfiniteStreamRecognize class#9498abhasal wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
minherz
left a comment
There was a problem hiding this comment.
what is an expected running time for this test?
based on lack of test input it looks like the code sample will wait for input and get terminated after 5 minutes.
| System.setErr(new PrintStream(stderr)); | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() { | ||
| System.setOut(originalStdout); | ||
| System.setErr(originalStderr); |
There was a problem hiding this comment.
nit: what is a reason to intercept Stderr if the test validates only Stdout?
|
I converted PR to draft because it does not pass automatic testing. Please, ensure that all tests pass before submitting it to the review. |
Description
Fixes #8261
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only