add enable field to packetmirroring resource

[Dawid212]

this pr adds enable field to packet mirroring resource

compute: added `enable` field to `google_compute_packet_mirroring`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[c2thorn]

we should test updating the value to false and then true again via an update test: https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test

[c2thorn]

for a top-level field like this, I'd prefer to use default_from_api: true instead of default_value to avoid suddenly enabling potentially dormant existing resources

[github-actions]

@Dawid212, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@Dawid212, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[c2thorn]

Hi @Dawid212, thanks for responding with an update.

I want to clarify that the update test should be a separate multi-step written-out test following these instructions: https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test

You would need to create a new test file in https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/services/compute for the packet mirroring resource

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 298 insertions(+))
google-beta provider: Diff ( 5 files changed, 298 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Tests analytics

Total tests: 1336
Passed tests: 1248
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputePacketMirroring_computePacketMirroringFullExample
• TestAccComputePacketMirroring_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputePacketMirroring_computePacketMirroringFullExample [Debug log]
TestAccComputePacketMirroring_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test