Skip to content

Conversation

@aditikumarii-google
Copy link
Contributor

sql: additional automated test for cross region and multiregion restore using `backupdr_backup`

@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn December 31, 2025 07:39
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 127 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 127 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 127 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 127 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 140
Passed tests: 110
Skipped tests: 26
Affected tests: 4

Click here to see the affected service packages
  • sql

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSqlDatabaseInstance_activationPolicy
  • TestAccSqlDatabaseInstance_createFromCrossRegionBackupDrBackup
  • TestAccSqlDatabaseInstance_createFromMultiRegionBackupDrBackup
  • TestAccSqlDatabaseInstance_createFromMultiRegionBackupDrBackupCrossRegion

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 140
Passed tests: 110
Skipped tests: 26
Affected tests: 4

Click here to see the affected service packages
  • sql

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSqlDatabaseInstance_activationPolicy
  • TestAccSqlDatabaseInstance_createFromCrossRegionBackupDrBackup
  • TestAccSqlDatabaseInstance_createFromMultiRegionBackupDrBackup
  • TestAccSqlDatabaseInstance_createFromMultiRegionBackupDrBackupCrossRegion

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_activationPolicy [Error message] [Debug log]
TestAccSqlDatabaseInstance_createFromCrossRegionBackupDrBackup [Error message] [Debug log]
TestAccSqlDatabaseInstance_createFromMultiRegionBackupDrBackup [Error message] [Debug log]
TestAccSqlDatabaseInstance_createFromMultiRegionBackupDrBackupCrossRegion [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_activationPolicy [Error message] [Debug log]
TestAccSqlDatabaseInstance_createFromCrossRegionBackupDrBackup [Error message] [Debug log]
TestAccSqlDatabaseInstance_createFromMultiRegionBackupDrBackup [Error message] [Debug log]
TestAccSqlDatabaseInstance_createFromMultiRegionBackupDrBackupCrossRegion [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@aditikumarii-google
Copy link
Contributor Author

@c2thorn These tests will pass once the changes in backend are rolled out in Prod

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@c2thorn
Copy link
Member

c2thorn commented Jan 2, 2026

@c2thorn These tests will pass once the changes in backend are rolled out in Prod

then we'll need to wait for now to merge. i'll reach out to you internally to verify timeline

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for rollout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants